| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fdw batch insert error out when set batch_size > 65535 |
| Date: | 2021-06-09 06:05:46 |
| Message-ID: | 1271666.1623218746@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
>> I've added a simple regression test to postgres_fdw, testing that batch
>> sizes > 65535 work fine, and pushed the fix.
> I was earlier thinking of adding one, but stopped because it might
> increase the regression test execution time. It looks like that's true
> - with and without the test case it takes 17 sec and 4 sec
> respectively on my dev system which is 4X slower. I'm not sure if this
> is okay.
The cost, versus the odds of ever detecting a problem, doesn't
seem like a good tradeoff.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2021-06-09 06:07:24 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |
| Previous Message | Amit Kapila | 2021-06-09 05:46:45 | Re: [HACKERS] logical decoding of two-phase transactions |