add missing errdetail for xlogreader allocation failure error

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: add missing errdetail for xlogreader allocation failure error
Date: 2021-11-19 03:59:15
Message-ID: CALj2ACV+cX1eM03GfcA=ZMLXh5fSn1X1auJLz3yuS1duPSb9QA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It seems like some of the XLogReaderAllocate failure check errors are
not having errdetail "Failed while allocating a WAL reading
processor." but just the errmsg "out of memory". The "out of memory"
message without the errdetail is too generic and let's add it for
consistency and readability of the message in the server logs.

Here's a tiny patch. Thoughts?

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v1-0001-add-missing-errdetail-for-xlogreader-allocation-f.patch application/octet-stream 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-11-19 04:16:09 Re: row filtering for logical replication
Previous Message Amit Kapila 2021-11-19 03:51:52 Re: Skipping logical replication transactions on subscriber side