Re: add missing errdetail for xlogreader allocation failure error

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: add missing errdetail for xlogreader allocation failure error
Date: 2021-11-22 11:58:36
Message-ID: 079D519B-0FA2-40DB-B373-8B58D52B69D9@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 19 Nov 2021, at 04:59, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:

> It seems like some of the XLogReaderAllocate failure check errors are
> not having errdetail "Failed while allocating a WAL reading
> processor." but just the errmsg "out of memory". The "out of memory"
> message without the errdetail is too generic and let's add it for
> consistency and readability of the message in the server logs.
>
> Here's a tiny patch. Thoughts?

No objections. There are quite a few more "out of memory" errors without
errdetail but that doesn't mean we can't move the needle with these.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-11-22 12:01:08 Re: add missing errdetail for xlogreader allocation failure error
Previous Message Amit Kapila 2021-11-22 11:42:00 Re: rename SnapBuild* macros in slot.c