Re: row filtering for logical replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-11-19 04:16:09
Message-ID: CAA4eK1JaxY_wDJeuJHJuUcrX318=5RtXo96tLVOcJzhOW6+5gw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 19, 2021 at 3:16 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Thu, Nov 18, 2021 at 4:32 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Mon, Nov 15, 2021 at 9:31 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Wed, Nov 10, 2021 at 12:36 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > > >
> > > > On Mon, Nov 8, 2021 at 5:53 PM houzj(dot)fnst(at)fujitsu(dot)com
> > > > <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > > > >
> > > > > 3) v37-0005
> > > > >
> > > > > - no parse nodes of any kind other than Var, OpExpr, Const, BoolExpr, FuncExpr
> > > > >
> > > > > I think there could be other node type which can also be considered as simple
> > > > > expression, for exmaple T_NullIfExpr.
> > > >
> > > > The current walker restrictions are from a previously agreed decision
> > > > by Amit/Tomas [1] and from an earlier suggestion from Andres [2] to
> > > > keep everything very simple for a first version.
> > > >
> > > > Yes, you are right, there might be some additional node types that
> > > > might be fine, but at this time I don't want to add anything different
> > > > without getting their approval to do so. Anyway, additions like this
> > > > are all candidates for a future version of this row-filter feature.
> > > >
> > >
> > > I think we can consider T_NullIfExpr unless you see any problem with the same.
> >
> > Added in v40 [1]
> >
>
> I've noticed that row-filters that are testing NULL cannot pass the
> current expression validation restrictions.
>
> e.g.1
> test_pub=# create publication ptest for table t1 where (a is null);
> ERROR: invalid publication WHERE expression for relation "t1"
> HINT: only simple expressions using columns, constants and immutable
> system functions are allowed
>
> e.g.2
> test_pub=# create publication ptest for table t1 where (a is not null);
> ERROR: invalid publication WHERE expression for relation "t1"
> HINT: only simple expressions using columns, constants and immutable
> system functions are allowed
>
> So I think it would be useful to permit the NullTest also. Is it OK?
>

Yeah, I think such simple expressions should be okay but we need to
test left-side expressions for simplicity.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-11-19 04:18:10 Re: row filtering for logical replication
Previous Message Bharath Rupireddy 2021-11-19 03:59:15 add missing errdetail for xlogreader allocation failure error