Re: Refactoring postgres_fdw code to rollback remote transaction

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring postgres_fdw code to rollback remote transaction
Date: 2021-09-17 06:33:54
Message-ID: CALj2ACUJALFeJ6+BcKeFnHAY9SG+WBM+q7jT1_4JCp_2kW3b3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 17, 2021 at 8:28 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> On 2021/09/17 11:40, Zhihong Yu wrote:
> > + goto fail; /* Trouble clearing prepared statements */
> >
> > The label fail can be removed. Under the above condition, entry->changing_xact_state is still true. You can directly return.
>
> Thanks for the review! Yes, you're right. Attached the updated version of the patch.

+1 for the code refactoring (1 file changed, 75 insertions(+), 102
deletions(-)).

The v2 patch looks good to me as is.

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-09-17 07:11:56 Re: Logical replication keepalive flood
Previous Message houzj.fnst@fujitsu.com 2021-09-17 06:22:14 RE: Logical replication keepalive flood