Re: Refactoring postgres_fdw code to rollback remote transaction

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring postgres_fdw code to rollback remote transaction
Date: 2021-09-17 02:58:35
Message-ID: 2a767435-9a92-a6fb-4b59-a81434dda1ab@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/09/17 11:40, Zhihong Yu wrote:
> +           goto fail;          /* Trouble clearing prepared statements */
>
> The label fail can be removed. Under the above condition,  entry->changing_xact_state is still true. You can directly return.

Thanks for the review! Yes, you're right. Attached the updated version of the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
refactor_pgfdw_rollback_v2.patch text/plain 6.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-09-17 03:10:17 Re: Split xlog.c
Previous Message Zhihong Yu 2021-09-17 02:40:06 Re: Refactoring postgres_fdw code to rollback remote transaction