| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring postgres_fdw code to rollback remote transaction |
| Date: | 2021-09-21 15:16:03 |
| Message-ID: | cbcab143-ea07-1c3d-f4cb-6f4f878acc0b@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/09/17 15:33, Bharath Rupireddy wrote:
> On Fri, Sep 17, 2021 at 8:28 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>> On 2021/09/17 11:40, Zhihong Yu wrote:
>>> + goto fail; /* Trouble clearing prepared statements */
>>>
>>> The label fail can be removed. Under the above condition, entry->changing_xact_state is still true. You can directly return.
>>
>> Thanks for the review! Yes, you're right. Attached the updated version of the patch.
>
> +1 for the code refactoring (1 file changed, 75 insertions(+), 102
> deletions(-)).
>
> The v2 patch looks good to me as is.
Thanks for the review! Barring any objection, I will commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-09-21 15:25:03 | Re: refactoring basebackup.c |
| Previous Message | Jeevan Ladhe | 2021-09-21 13:35:01 | Re: refactoring basebackup.c |