| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 12:46:58 |
| Message-ID: | CALdSSPivsz8FH3p68dRnEtruvsA+9FQqYB_WXpcNY6BLT19N4g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>
>
> > I agree — the NULL handling seems wrong.
> > Here's a quick patch to fix it. What do you think?
>
> LGTM, but maybe the test should be expanded with NULL for the two-column
> indexes? I mean to add NULLs at zero column too.
>
> Also, about the tests but not related to NULLs...
> Seems like we need to run those tests on 32bit system, the test output should be different?
Yes, gin_1.out is for 32-bit output. Adding new tuples in relation
will result in binary layout changes, so we need to update gin.out for
64 bit and gin_1.out for 32 bit
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-01-14 12:53:16 | Re: Add IS_INDEX macro to brin and gist index |
| Previous Message | Roman Khapov | 2026-01-14 12:44:32 | Re: GIN pageinspect support for entry tree and posting tree |