Re: GIN pageinspect support for entry tree and posting tree

From: Roman Khapov <rkhapov(at)yandex-team(dot)ru>
To: Japin Li <japinli(at)hotmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GIN pageinspect support for entry tree and posting tree
Date: 2026-01-14 12:44:32
Message-ID: 9CFF5492-B542-4BE7-9093-E32EBC7DDB1C@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> I agree — the NULL handling seems wrong.
> Here's a quick patch to fix it. What do you think?

LGTM, but maybe the test should be expanded with NULL for the two-column
indexes? I mean to add NULLs at zero column too.

Also, about the tests but not related to NULLs...
Seems like we need to run those tests on 32bit system, the test output should be different?

--
Best regards,
Roman Khapov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2026-01-14 12:46:58 Re: GIN pageinspect support for entry tree and posting tree
Previous Message Kirill Reshke 2026-01-14 12:40:52 Re: GIN pageinspect support for entry tree and posting tree