| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Roman Khapov <rkhapov(at)yandex-team(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 15:06:14 |
| Message-ID: | SYAPR01MB3038F736792DE8876750FBDBB68FA@SYAPR01MB3038.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Kirill
On Wed, 14 Jan 2026 at 17:46, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>>
>>
>> > I agree — the NULL handling seems wrong.
>> > Here's a quick patch to fix it. What do you think?
>>
>> LGTM, but maybe the test should be expanded with NULL for the two-column
>> indexes? I mean to add NULLs at zero column too.
>>
>> Also, about the tests but not related to NULLs...
>> Seems like we need to run those tests on 32bit system, the test output should be different?
>
> Yes, gin_1.out is for 32-bit output. Adding new tuples in relation
> will result in binary layout changes, so we need to update gin.out for
> 64 bit and gin_1.out for 32 bit
>
I only have a 64-bit system to work with.
I'm unsure how to produce the correct gin_1.out file for 32-bit architecture
while running on 64-bit.
Any advice or recommended workflow would be greatly appreciated!
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-01-14 15:07:41 | Re: Add IS_INDEX macro to brin and gist index |
| Previous Message | Kirill Reshke | 2026-01-14 15:03:10 | Re: GIN pageinspect support for entry tree and posting tree |