| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Roman Khapov <rkhapov(at)yandex-team(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, michael(at)paquier(dot)xyz |
| Subject: | Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist |
| Date: | 2025-12-29 19:29:49 |
| Message-ID: | CALdSSPifaAAiOe8LqTJCAcuJ9BMnpQsEPnCojDMGHsUopWjoXA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 30 Dec 2025 at 00:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Kirill Reshke <reshkekirill(at)gmail(dot)com> writes:
> > Should we then refactor code to avoid copying? I copied this code in
> > [0] for the third time, so if this has a chance to be committed, there
> > will be 3 times copied code...
>
> Might not be a bad idea, but of course the devil is in the details.
> What did you have in mind? Split out a function to quote one
> field value per record_out's rules?
>
> regards, tom lane
Yes, split out a function that does quoting after
OidOutputFunctionCall. that is, this:
https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/rowtypes.c#L437-L464
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2025-12-29 20:04:53 | Re: lsyscache: free IndexAmRoutine objects returned by GetIndexAmRoutineByAmId() |
| Previous Message | Tom Lane | 2025-12-29 19:24:49 | Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist |