Re: lsyscache: free IndexAmRoutine objects returned by GetIndexAmRoutineByAmId()

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: lsyscache: free IndexAmRoutine objects returned by GetIndexAmRoutineByAmId()
Date: 2025-12-29 20:04:53
Message-ID: CAEze2WiFDiHVDxdW9BC0siF7kEqdiz0vP6Cb8s3u0e30zK7r-g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 29 Dec 2025 at 20:01, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> writes
>> Here's my patch that does this, pulled from [0]. It was originally
>> built to reduce the per-index catcache overhead; as using static const
>> pointers reduces the data allocated into the "index info" context by
>> 264 bytes.
>
> Cool, I forgot you'd already been poking at this. The patch
> is kinda long, but not as bad as I feared, and it all looks
> quite mechanical. It lacks documentation updates though.

Attached v2, in which I've updated the one place where I could find
IndexAmRoutine's allocation policy being described, and in which I've
also updated InitIndexAmRoutine with the suggested changes of your
other mail. Thanks!

Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)

Attachment Content-Type Size
v2-0001-Stop-allocating-one-IndexAmRoutine-for-every-inde.patch application/octet-stream 46.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilia Evdokimov 2025-12-29 20:35:43 Hash-based MCV matching for large IN-lists
Previous Message Kirill Reshke 2025-12-29 19:29:49 Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist