Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Roman Khapov <rkhapov(at)yandex-team(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, michael(at)paquier(dot)xyz
Subject: Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
Date: 2025-12-29 19:24:49
Message-ID: 2993271.1767036289@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kirill Reshke <reshkekirill(at)gmail(dot)com> writes:
> Should we then refactor code to avoid copying? I copied this code in
> [0] for the third time, so if this has a chance to be committed, there
> will be 3 times copied code...

Might not be a bad idea, but of course the devil is in the details.
What did you have in mind? Split out a function to quote one
field value per record_out's rules?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-12-29 19:29:49 Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
Previous Message Kirill Reshke 2025-12-29 19:17:47 Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist