| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amitkapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Rename sync_error_count to tbl_sync_error_count in subscription statistics |
| Date: | 2025-11-12 04:23:56 |
| Message-ID: | CALDaNm3WwJmz=-4ybTkhniB-Nf3qmFG9Zx1uKjyLLoPF5NYYXA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
This patch proposes renaming a column in the view
pg_stat_subscription_stats to disambiguate between table sync and
sequence sync error counts. With the introduction of
seq_sync_error_count, the existing column name sync_error_count
becomes ambiguous, it's unclear whether it refers to tables,
sequences, or both. Renaming it to tbl_sync_error_count makes the
meaning explicit: it represents errors that occurred during table
synchronization. This helps users avoid confusion when interpreting
the view's output. These changes were also suggested by Amit's first
comment at [1] and Peter's fourth comment at [2].
Thoughts?
Since an existing column is being renamed, this change should also be
mentioned in the release notes so that users can update any scripts or
monitoring queries that reference it.
[1] - https://www.postgresql.org/message-id/CAA4eK1LB7u2KQLRFh6xfTSpEB-8gbpR%3DhqzFOfL9Z1R8rj7Q5g%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAHut%2BPtoLN0bRu7bNiSeF04dQQecoW-EXKMBX%3DHy0uqCvQa8MA%40mail.gmail.com
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-sync_error_count-to-tbl_sync_error_count-in-s.patch | application/octet-stream | 9.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-11-12 04:33:40 | Re: Is this a typo? |
| Previous Message | Amit Kapila | 2025-11-12 04:22:09 | Re: Issue with logical replication slot during switchover |