Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amitkapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics
Date: 2025-11-12 05:04:29
Message-ID: CAJpy0uDY+JgByVmH7hTUfPf6XB9W1yNFWEGUm6d=Esihk-C3TA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 12, 2025 at 9:54 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> This patch proposes renaming a column in the view
> pg_stat_subscription_stats to disambiguate between table sync and
> sequence sync error counts. With the introduction of
> seq_sync_error_count, the existing column name sync_error_count
> becomes ambiguous, it's unclear whether it refers to tables,
> sequences, or both. Renaming it to tbl_sync_error_count makes the
> meaning explicit: it represents errors that occurred during table
> synchronization. This helps users avoid confusion when interpreting
> the view's output.

+1 on the intent. It will definitely help avoid confusion in the names.

I’m slightly leaning toward using 'table_sync_error_count' instead of
'tbl_sync_error_count'. The name 'table_sync_error_count' isn’t too
long and should work fine, while 'tbl_..' feels more like an internal
variable name. But I would like to see what others prefer here.

thanks
Shveta

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-11-12 05:16:12 Type of pg_buffercache_pages()::forknum
Previous Message Henson Choi 2025-11-12 04:53:50 [PATCH] Fix translation consistency issues in Korean, Chinese Traditional, and Tamil