| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics |
| Date: | 2025-11-13 09:52:29 |
| Message-ID: | CALDaNm3S_c0miN2VZGzOXgw1OT0mpiWYoBpVnsMqvSVDGqtELg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 13 Nov 2025 at 09:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > CURRENT
> > seq_sync_error_count
> > sync_error_count
> >
> > MY SUGGESTION
> > sync_seq_error_count
> > sync_table_error_count
> >
>
> +1. Along with consistency with other column names, it will also make
> it easier for users to group and query all 'sync' related counts
> together.
This seems better, the attached v2 version patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Rename-sync_error_count-to-sync_table_error_count.patch | application/octet-stream | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-11-13 09:55:56 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Yugo Nagata | 2025-11-13 09:40:36 | Re: Suggestion to add --continue-client-on-abort option to pgbench |