| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics |
| Date: | 2025-11-17 11:05:16 |
| Message-ID: | CAA4eK1J7fbn0T2Szybnp6KUr4M4ug0qBDzDBNWoVYp=UDJNNYw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 13, 2025 at 3:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 13 Nov 2025 at 09:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > CURRENT
> > > seq_sync_error_count
> > > sync_error_count
> > >
> > > MY SUGGESTION
> > > sync_seq_error_count
> > > sync_table_error_count
> > >
> >
> > +1. Along with consistency with other column names, it will also make
> > it easier for users to group and query all 'sync' related counts
> > together.
>
> This seems better, the attached v2 version patch has the changes for the same.
>
The patch looks good to me. I'll push this tomorrow unless there are
any new reviews or suggestions.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-11-17 11:11:42 | Re: [PATCH] jit: fix build with LLVM-21 |
| Previous Message | Thomas Munro | 2025-11-17 10:58:26 | Re: Fix build of llvmjit_types.bc with meson |