| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics |
| Date: | 2025-11-14 03:30:21 |
| Message-ID: | CAHut+Ptc-XmezMPNjMwUSAPD6HrR+W6Jd-2AkXUXbA232q1szA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 13, 2025 at 8:52 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 13 Nov 2025 at 09:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > CURRENT
> > > seq_sync_error_count
> > > sync_error_count
> > >
> > > MY SUGGESTION
> > > sync_seq_error_count
> > > sync_table_error_count
> > >
> >
> > +1. Along with consistency with other column names, it will also make
> > it easier for users to group and query all 'sync' related counts
> > together.
>
> This seems better, the attached v2 version patch has the changes for the same.
>
LGTM.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-11-14 03:52:54 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Ajin Cherian | 2025-11-14 03:17:31 | Re: Add support for COPY TO in tablesync for partitioned tables. |