Re: Review items for EXCEPT TABLE publication

On Fri, 11 Sept 2026 at 11:21, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Sep 10, 2026 at 11:09 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Finding #5: SET UNLOGGED on an excluded table produces an unrestorable
> > catalog state
> >
>
> + if (!toLogged &&
> + GetRelationExcludedPublications(RelationGetRelid(rel)) != NIL)
> + ereport(ERROR,
> + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> + errmsg("cannot change table \"%s\" to unlogged because i
>
> Can we have one unified function to check whether a table is part of
> any publication and get an additional out parameter whether that is an
> include or exclude table? As we can't have the same table both
> included and excluded, this should work unless I am missing something.

Here is an updated v4 version patch to handle the same.

Regards,
Vignesh