Re: Review items for EXCEPT TABLE publication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Review items for EXCEPT TABLE publication
Date: 2026-09-11 05:51:27
Message-ID: CAA4eK1JHX47ER=0ubhJG5oQO8RH=U5vjDBO2J9V6n1+Ra_rpJQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 10, 2026 at 11:09 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Finding #5: SET UNLOGGED on an excluded table produces an unrestorable
> catalog state
>

+ if (!toLogged &&
+ GetRelationExcludedPublications(RelationGetRelid(rel)) != NIL)
+ ereport(ERROR,
+ (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+ errmsg("cannot change table \"%s\" to unlogged because i

Can we have one unified function to check whether a table is part of
any publication and get an additional out parameter whether that is an
include or exclude table? As we can't have the same table both
included and excluded, this should work unless I am missing something.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2026-09-11 06:00:41 Re: Crashes on a partition whose concurrent detach never finished
Previous Message Amit Kapila 2026-09-11 05:39:12 Re: Review items for EXCEPT TABLE publication