| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid |
| Date: | 2026-04-16 10:55:31 |
| Message-ID: | CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 16 Apr 2026 at 09:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > I felt these also should be updated, the attached v2 version patch
> > includes the changes for the same.
>
> Thanks for updating the patch!
>
> - applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> + applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
>
> XLogRecPtrIsValid() should be used here, instead?
Yes, that seems better, the attached v3 version patch has the changes
for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Use-XLogRecPtr-validity-helper-macros-consistentl.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mihail Nikalayeu | 2026-04-16 11:18:55 | Re: Adding REPACK [concurrently] |
| Previous Message | Nisha Moond | 2026-04-16 10:54:05 | Re: Support EXCEPT for TABLES IN SCHEMA publications |