Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date: 2026-04-16 04:11:52
Message-ID: CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> I felt these also should be updated, the attached v2 version patch
> includes the changes for the same.

Thanks for updating the patch!

- applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
+ applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?

XLogRecPtrIsValid() should be used here, instead?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haibo Yan 2026-04-16 04:12:35 Re: Implement missing join selectivity estimation for range types
Previous Message Chao Li 2026-04-16 04:02:48 Re: Use proc_exit() in WalRcvWaitForStartPosition