| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid |
| Date: | 2026-04-16 12:30:38 |
| Message-ID: | CAAJ_b975xBx_No+i69F5EAcRgDaT-G0h=XPFrqL1n_zBSwKSRQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 16, 2026 at 4:25 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 16 Apr 2026 at 09:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > I felt these also should be updated, the attached v2 version patch
> > > includes the changes for the same.
> >
> > Thanks for updating the patch!
> >
> > - applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> > + applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
> >
> > XLogRecPtrIsValid() should be used here, instead?
The outer parentheses do not seem to be needed, as
XLogRecPtrIsInvalid() already includes them.
Other than that, the v3 patch looks good to me.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chengpeng Yan | 2026-04-16 13:01:38 | [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators |
| Previous Message | lakshmi | 2026-04-16 12:10:32 | Re: Pgbench: remove synchronous prepare |