| From: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Crash in add_paths_to_append_rel |
| Date: | 2023-10-10 04:48:17 |
| Message-ID: | CAKU4AWr=OKPbaQBtJsdY0LAOW4r8aeU+EgCJdqjai_TnEv1U8A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 10, 2023 at 11:52 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > I came across a crash in add_paths_to_append_rel() with the query below.
>
> > It was introduced by commit a8a968a8 where we referenced
> > cheapest_startup_path->param_info without first checking that we have a
> > valid cheapest_startup_path.
>
> I pushed this with just minor adjustments to the comments you wrote. I
> didn't feel the need to reiterate on the set_cheapest() comments.
>
>
Thanks Richard for the report and also Thanks you David for the push!
--
Best Regards
Andy Fan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2023-10-10 04:55:29 | Minor edit to src/bin/pg_upgrade/IMPLEMENTAION |
| Previous Message | Michael Paquier | 2023-10-10 04:36:01 | Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag |