Re: Crash in add_paths_to_append_rel

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Crash in add_paths_to_append_rel
Date: 2023-10-10 03:52:05
Message-ID: CAApHDvrNk2X6y592S5esBchTOJuvjnGWwX9-epSK3EGoaqfwOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> I came across a crash in add_paths_to_append_rel() with the query below.

> It was introduced by commit a8a968a8 where we referenced
> cheapest_startup_path->param_info without first checking that we have a
> valid cheapest_startup_path.

I pushed this with just minor adjustments to the comments you wrote. I
didn't feel the need to reiterate on the set_cheapest() comments.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-10-10 04:14:15 Re: Lowering the default wal_blocksize to 4K
Previous Message Thomas Munro 2023-10-10 03:17:57 Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific