Re: pgsql: Clarify use of temporary tables within partition trees

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Clarify use of temporary tables within partition trees
Date: 2018-07-03 06:16:40
Message-ID: CAKJS1f8h8283Vb2NcQH+YOMErdDQZWGuqGoe-gX6yT8TKGf0MA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 3 July 2018 at 18:11, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 03, 2018 at 06:00:46PM +1200, David Rowley wrote:
>> I think it should be backpatched to v11 and v10. Your original commit
>> went there too. I don't see any reason to do any different here than
>> what you did with the original commit.
>
> expand_partitioned_rtentry is new as of v11. Or you mean to tweak
> expand_inherited_rtentry() perhaps? I am not sure that it is worth it
> as the code has already diverged between 10 and 11.

Oh right. I'd forgotten that changed in v11. I think the v10 code is
fine as is then.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2018-07-03 06:29:36 Re: pgsql: Clarify use of temporary tables within partition trees
Previous Message Michael Paquier 2018-07-03 06:11:19 Re: pgsql: Clarify use of temporary tables within partition trees

Browse pgsql-hackers by date

  From Date Subject
Next Message Arseny Sher 2018-07-03 06:16:42 Re: Possible bug in logical replication.
Previous Message Michael Paquier 2018-07-03 06:11:19 Re: pgsql: Clarify use of temporary tables within partition trees