Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, ND Abelisto <abelisto(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Date: 2018-08-21 11:12:34
Message-ID: CAKJS1f-5m+RXkRQbGh7AKng5mcW_68aP9uytHKCP5bFyRmBJDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 21 August 2018 at 17:46, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 21 August 2018 at 13:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> I was just looking at this issue, or both of you are already on it?
>
> It's already in my head what it should look like, so I can write it,
> although it might not appear until tomorrow, as I've reached the end
> of my day now.

I've attached what I had in mind. The header comment for
getOwnedSeqs() gives me the impression this is the best place to
locate this code.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
pg_dump_identity_seq_fix.patch application/octet-stream 1.0 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-21 13:01:49 Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Previous Message Dmitry Dolgov 2018-08-21 09:18:55 Re: csvlog gets crazy when csv file is not writable