Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, ND Abelisto <abelisto(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Date: 2018-08-21 13:01:49
Message-ID: 45913d0f-d395-3099-9dff-20fc8316848c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 21/08/2018 13:12, David Rowley wrote:
> On 21 August 2018 at 17:46, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> On 21 August 2018 at 13:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>> I was just looking at this issue, or both of you are already on it?
>>
>> It's already in my head what it should look like, so I can write it,
>> although it might not appear until tomorrow, as I've reached the end
>> of my day now.
>
> I've attached what I had in mind. The header comment for
> getOwnedSeqs() gives me the impression this is the best place to
> locate this code.

Yes, that looks good to me.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2018-08-21 14:23:45 BUG #15344: pg_proc.proisagg was removed incompatibly in PostgreSQL 11
Previous Message David Rowley 2018-08-21 11:12:34 Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column