Re: pg_upgrade does not upgrade pg_stat_statements properly

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Dave Cramer <davecramer(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: 2021-07-29 04:35:28
Message-ID: CAKFQuwaZ_OQw4f_x3RM2hN5_XnM6NT2xW7sT-6a5R5=Qz+7Udw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> I came up with the attached patch.
>

Thank you. It is an improvement but I think more could be done here (not
exactly sure what - though removing the "copy binaries for contrib modules
from the old server" seems like a decent second step.)

I'm not sure it really needs a parenthetical, and I personally dislike
using "Consider" to start the sentence.

"Bringing extensions up to the newest version available on the new server
can be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
binaries are installed)."

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-07-29 04:49:19 Re: needless complexity in StartupXLOG
Previous Message Yugo NAGATA 2021-07-29 04:23:25 Re: pgbench bug candidate: negative "initial connection time"