Re: pg_upgrade does not upgrade pg_stat_statements properly

On Thu, 29 Jul 2021 at 00:35, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
wrote:

> On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
>> I came up with the attached patch.
>>
>
> Thank you. It is an improvement but I think more could be done here (not
> exactly sure what - though removing the "copy binaries for contrib modules
> from the old server" seems like a decent second step.)
>
> I'm not sure it really needs a parenthetical, and I personally dislike
> using "Consider" to start the sentence.
>
> "Bringing extensions up to the newest version available on the new server
> can be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
> binaries are installed)."
>

As for the patch. What exactly is being copied ?
This is all very confusing. Some of the extensions will work perfectly fine
on the new server without an upgrade. At least one of the extensions will
appear to function perfectly fine with new binaries and old function
definitions.
Seems to me we need to do more.

Dave