| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-17 02:59:58 |
| Message-ID: | CAJpy0uDqrni43U8gx2quMDt-w5EKHrYj3OAkDVmir3NVqOBDkA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 16, 2026 at 10:27 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 16 Sept 2026 at 14:26, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Wed, 16 Sept 2026 at 13:57, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > >
> > > I don’t think the fix would add much complexity, please see the attached diff I tried. This error message is shown to users, so I think improving it is worthwhile.
> >
> > Agreed. I had initially thought the additional code complexity was not
> > worthwhile. Since this is a user-facing error message, I agree that
> > making it more specific is worthwhile. Thanks, I have merged the
> > changes.
> > The attached v5 version patch has the changes for the same.
>
> While reviewing the patch further, I noticed that the Assert in
> get_object_address_publication_rel() can be placed immediately after
> the variable declarations, rather than after the subsequent checks.
> The attached v6 patch includes this change.
>
v6 LGTM.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-09-17 03:04:11 | Re: Make pg_prewarm, autoprewarm yield for waiting DDL |
| Previous Message | Tom Lane | 2026-09-17 02:51:59 | Re: remove_useless_joins vs. bug #19560 |