| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-16 16:57:29 |
| Message-ID: | CALDaNm18azW2vciTHd=5xesJ-xMkty8CKutGKxCkGZUZd++8dg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 16 Sept 2026 at 14:26, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 16 Sept 2026 at 13:57, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > I don’t think the fix would add much complexity, please see the attached diff I tried. This error message is shown to users, so I think improving it is worthwhile.
>
> Agreed. I had initially thought the additional code complexity was not
> worthwhile. Since this is a user-facing error message, I agree that
> making it more specific is worthwhile. Thanks, I have merged the
> changes.
> The attached v5 version patch has the changes for the same.
While reviewing the patch further, I noticed that the Assert in
get_object_address_publication_rel() can be placed immediately after
the variable declarations, rather than after the subsequent checks.
The attached v6 patch includes this change.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Distinguish-publication-exclusions-in-object-addr.patch | application/octet-stream | 23.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-09-16 16:59:09 | Re: REPACK enhancements |
| Previous Message | Alberto Piai | 2026-09-16 16:55:58 | Re: Unexpected reindex when altering column types for partitioned tables |