| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |
| Date: | 2026-10-07 03:43:28 |
| Message-ID: | CAJpy0uDGaBarxJLJ812XbcZSknDbnqxE_XQnEojuRvsS0aD5Bw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 6, 2026 at 11:16 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Mon, Oct 5, 2026 at 8:24 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Tue, Oct 6, 2026 at 3:57 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > On Thu, Oct 1, 2026 at 4:08 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > > >
> > > > On Sat, Sep 26, 2026 at 3:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > > > >
> > > > >
> > > > > I've incorporated your comment suggestions, and updated cosmetic
> > > > > things.Please review them.
> > > > >
> > > >
> > > > Hi,
> > > > I reviewed the TAP test and it LGTM. I found no correctness issues,
> > > > just a couple of nits compared to the neighboring tests. Please
> > > > consider these if they look okay to you:
> > > >
> > > > 1) Add the sync_slot condition to injection_points_attach() similar to
> > > > the neighboring tests, so the wait happens only when sync_slot itself
> > > > is being created.
> > > > 2) Add a note() after wait_for_event(), as in the other tests, so the
> > > > test output shows when the sync is paused at the injection point.
> > > >
> > >
> > > Both suggestions look good to me. I've incorporated these suggestions
> > > and updated the comment as discussed with Amit. I've attached the
> > > updated patch.
> > >
> >
> > Sawada-san, I don't see any difference between v3 and v4, can you
> > please check and confirm?
>
> Oops, sorry I forgot to include the changes to the patches when doing
> git format-patch. I've attached the correct one.
>
Thanks, the patches LGTM.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-07 03:58:00 | Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash |
| Previous Message | Sho Ito | 2026-10-07 03:23:29 | Re: [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE |