Re: [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE

Hi Haruna,

Thank you for updating the patch. I tested v2 and confirmed that all three
forms now complete to `ON` as expected.
Now it looks good to me.

Thanks,
Sho

On Tue, Oct 6, 2026 at 4:30 AM Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> wrote:

> Hi, Sho
>
> Thank you for testing the patch and for your feedback.
>
> I've updated the patch to also handle the `REVOKE GRANT OPTION FOR CREATE`
> case,
> so it now reaches the same privilege-completion rule and suggests `ON` as
> expected.
>
> Attached is the updated patch.
>
> Regards,
> Haruna
>
>
>
> ------------------------------
> *From:* Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
> *Sent:* Monday, October 5, 2026 7:03
> *To:* Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp>
> *Cc:* pgsql-hackers(at)postgresql(dot)org <pgsql-hackers(at)postgresql(dot)org>
> *Subject:* Re: [PATCH] psql: avoid CREATE command completion after
> GRANT/REVOKE CREATE
>
> Hi Haruna,
>
> I tested the patch and confirmed that `GRANT CREATE` and `REVOKE CREATE`
> now complete to `ON` as expected, including lowercase input.
>
> I also found that `REVOKE GRANT OPTION FOR CREATE` should reach the same
> privilege-completion rule, but the earlier `TailMatches("CREATE")` branch
> still intercepts it and offers CREATE object types instead of `ON`.
>
> Perhaps it would be a good idea to cover this form in the same patch. What
> do you think?
>
> Thanks,
> Sho Ito
>
> On Sun, Oct 4, 2026 at 5:57 PM Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> wrote:
>
> Hi,
>
> While testing psql tab completion, I noticed that the generic CREATE
> completion rule is triggered after GRANT CREATE and REVOKE CREATE.
>
> This results in irrelevant CREATE object type suggestions being offered
> in those contexts.
>
> I created a patch to exclude GRANT CREATE and REVOKE CREATE from the
> generic CREATE completion rule.
>
> Regards,
>
> Haruna Miwa
>
> --
> Haruna Miwa
>
>
>
> --
> ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
> *Sho Ito (Sean)*
>
> E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
> LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/*
> <https://www.linkedin.com/in/sho-ito-0628/>
> GitHub: https://github.com/sean0628/
> ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
>

--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝