Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation
Date: 2026-10-06 05:46:04
Message-ID: CAD21AoB-QLppfTma=F9E83RjBm97b6Ofa+yePeQapao9LaLy5w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 5, 2026 at 8:24 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, Oct 6, 2026 at 3:57 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Thu, Oct 1, 2026 at 4:08 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > > On Sat, Sep 26, 2026 at 3:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > I've incorporated your comment suggestions, and updated cosmetic
> > > > things.Please review them.
> > > >
> > >
> > > Hi,
> > > I reviewed the TAP test and it LGTM. I found no correctness issues,
> > > just a couple of nits compared to the neighboring tests. Please
> > > consider these if they look okay to you:
> > >
> > > 1) Add the sync_slot condition to injection_points_attach() similar to
> > > the neighboring tests, so the wait happens only when sync_slot itself
> > > is being created.
> > > 2) Add a note() after wait_for_event(), as in the other tests, so the
> > > test output shows when the sync is paused at the injection point.
> > >
> >
> > Both suggestions look good to me. I've incorporated these suggestions
> > and updated the comment as discussed with Amit. I've attached the
> > updated patch.
> >
>
> Sawada-san, I don't see any difference between v3 and v4, can you
> please check and confirm?

Oops, sorry I forgot to include the changes to the patches when doing
git format-patch. I've attached the correct one.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v5-0001-Add-an-init-callback-for-the-logical-decoding-con.patch text/x-patch 1.9 KB
v5-0002-Fix-slotsync-when-logical-decoding-is-disabled-an.patch text/x-patch 16.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-10-06 05:56:21 Re: subquery pullup misses lateral refs in join alias Vars
Previous Message ZizhuanLiu X-MAN 2026-10-06 05:40:29 Re: Optimize MCV stats for sortable types and utilize sorted-order properties