Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation
Date: 2026-10-06 03:24:39
Message-ID: CAJpy0uCYDi5-Yv7e9BDGOvoBb4tm0m=qh7oQMwtTrDDerWbR4w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 6, 2026 at 3:57 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Oct 1, 2026 at 4:08 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > On Sat, Sep 26, 2026 at 3:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > >
> > > I've incorporated your comment suggestions, and updated cosmetic
> > > things.Please review them.
> > >
> >
> > Hi,
> > I reviewed the TAP test and it LGTM. I found no correctness issues,
> > just a couple of nits compared to the neighboring tests. Please
> > consider these if they look okay to you:
> >
> > 1) Add the sync_slot condition to injection_points_attach() similar to
> > the neighboring tests, so the wait happens only when sync_slot itself
> > is being created.
> > 2) Add a note() after wait_for_event(), as in the other tests, so the
> > test output shows when the sync is paused at the injection point.
> >
>
> Both suggestions look good to me. I've incorporated these suggestions
> and updated the comment as discussed with Amit. I've attached the
> updated patch.
>

Sawada-san, I don't see any difference between v3 and v4, can you
please check and confirm?

thanks
Shveta

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-10-06 03:25:37 Re: Row pattern recognition
Previous Message Paul A Jungwirth 2026-10-06 03:08:06 Re: [SP-]GiST IOS visibility bug (was: Why doens't GiST require super-exclusive lock)