| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |
| Date: | 2026-10-05 22:26:46 |
| Message-ID: | CAD21AoCTWJLMEqcDBk83108daYdAoU_KLTMsgWwJ5WLO3BUm0g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 1, 2026 at 4:08 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Sat, Sep 26, 2026 at 3:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> >
> > I've incorporated your comment suggestions, and updated cosmetic
> > things.Please review them.
> >
>
> Hi,
> I reviewed the TAP test and it LGTM. I found no correctness issues,
> just a couple of nits compared to the neighboring tests. Please
> consider these if they look okay to you:
>
> 1) Add the sync_slot condition to injection_points_attach() similar to
> the neighboring tests, so the wait happens only when sync_slot itself
> is being created.
> 2) Add a note() after wait_for_event(), as in the other tests, so the
> test output shows when the sync is paused at the injection point.
>
Both suggestions look good to me. I've incorporated these suggestions
and updated the comment as discussed with Amit. I've attached the
updated patch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-an-init-callback-for-the-logical-decoding-con.patch | text/x-patch | 1.9 KB |
| v4-0002-Fix-slotsync-when-logical-decoding-is-disabled-an.patch | text/x-patch | 16.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-05 22:27:24 | Re: WAL segment file descriptor leak on read errors can PANIC the server |
| Previous Message | Michael Paquier | 2026-10-05 22:25:33 | Re: WAL segment file descriptor leak on read errors can PANIC the server |