Re: Added schema level support for publication.

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>
Subject: Re: Added schema level support for publication.
Date: 2021-06-24 08:42:37
Message-ID: CAJcOf-c_4RZq-BF=pQfCFWz-hB04u2-vDYU7neE47UDC3qHanA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 24, 2021 at 4:41 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> I applied your V7* patch and complied it. The following warnings came out, please take a look.
>

I encountered the following warnings when building with the v7 patches applied:
(looks like missing #include "catalog/objectaddress.h")

pg_prewarm.c:109:29: warning: implicit declaration of function
‘get_relkind_objtype’; did you mean ‘get_element_type’?
[-Wimplicit-function-declaration]
aclcheck_error(aclresult,
get_relkind_objtype(rel->rd_rel->relkind), get_rel_name(relOid));
^~~~~~~~~~~~~~~~~~~
get_element_type

heap_surgery.c:391:9: warning: implicit declaration of function
‘get_relkind_objtype’; did you mean ‘get_publication_type’?
[-Wimplicit-function-declaration]
get_relkind_objtype(rel->rd_rel->relkind),
^~~~~~~~~~~~~~~~~~~
get_publication_type

pgrowlocks.c:136:29: warning: implicit declaration of function
‘get_relkind_objtype’ [-Wimplicit-function-declaration]
aclcheck_error(aclresult, get_relkind_objtype(rel->rd_rel->relkind),

Regards,
Greg Nancarrow
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boris Kolpackov 2021-06-24 09:00:20 Re: Pipeline mode and PQpipelineSync()
Previous Message Peter Eisentraut 2021-06-24 08:12:49 Re: wrong relkind error messages