From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
Subject: | Re: Added schema level support for publication. |
Date: | 2021-06-24 18:17:44 |
Message-ID: | CALDaNm0BSy2tz6jZ-OSnmkYeosT7LQ=-rsRHP1M9-eMM7tm2gA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 24, 2021 at 2:12 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, Jun 24, 2021 at 4:41 PM tanghy(dot)fnst(at)fujitsu(dot)com
> <tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > I applied your V7* patch and complied it. The following warnings came
out, please take a look.
> >
>
> I encountered the following warnings when building with the v7 patches
applied:
> (looks like missing #include "catalog/objectaddress.h")
>
> pg_prewarm.c:109:29: warning: implicit declaration of function
> ‘get_relkind_objtype’; did you mean ‘get_element_type’?
> [-Wimplicit-function-declaration]
> aclcheck_error(aclresult,
> get_relkind_objtype(rel->rd_rel->relkind), get_rel_name(relOid));
> ^~~~~~~~~~~~~~~~~~~
> get_element_type
>
> heap_surgery.c:391:9: warning: implicit declaration of function
> ‘get_relkind_objtype’; did you mean ‘get_publication_type’?
> [-Wimplicit-function-declaration]
> get_relkind_objtype(rel->rd_rel->relkind),
> ^~~~~~~~~~~~~~~~~~~
> get_publication_type
>
> pgrowlocks.c:136:29: warning: implicit declaration of function
> ‘get_relkind_objtype’ [-Wimplicit-function-declaration]
> aclcheck_error(aclresult, get_relkind_objtype(rel->rd_rel->relkind),
>
Thanks for reporting these warnings, I have fixed this in the v8 patch
attached at [1].
[1] -
https://www.postgresql.org/message-id/CALDaNm044P_cds1OxZvFse5rE_qQfhbUg5MdtMgsa7t_bZGJdw%40mail.gmail.com
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2021-06-24 18:25:02 | Re: Added schema level support for publication. |
Previous Message | Fabien COELHO | 2021-06-24 18:15:02 | Re: pgbench using COPY FREEZE |