Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Date: 2025-05-07 08:47:24
Message-ID: CAJ7c6TPu3LTabgFkGUwuMKBbsMs_mk9H4Rz8cged8yX+V8+oqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alexander,

> Refactor ChangeVarNodesExtended() using the custom callback
>
> fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic
> to ChangeVarNodes_walker(). This commit provides refactoring to remove the
> SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to
> ChangeVarNodesExtended(), which has a chance to process a node before
> ChangeVarNodes_walker(). Passing this callback to ChangeVarNodesExtended()
> allows SJE-related node handling to be kept within the analyzejoins.c.

I believe this was pushed by mistake.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2025-05-07 08:51:06 Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Previous Message Alexander Korotkov 2025-05-07 08:15:26 pgsql: Refactor ChangeVarNodesExtended() using the custom callback