From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor ChangeVarNodesExtended() using the custom callback |
Date: | 2025-05-07 08:15:26 |
Message-ID: | E1uCZw6-000aRI-13@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor ChangeVarNodesExtended() using the custom callback
fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic
to ChangeVarNodes_walker(). This commit provides refactoring to remove the
SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to
ChangeVarNodesExtended(), which has a chance to process a node before
ChangeVarNodes_walker(). Passing this callback to ChangeVarNodesExtended()
allows SJE-related node handling to be kept within the analyzejoins.c.
Reported-by: Richard Guo <guofenglinux(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com
Author: Andrei Lepikhov <lepihov(at)gmail(dot)com>
Author: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ab42d643c14509cf1345588f55d798284b11a91e
Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c | 160 +++++++++++++++++++++++++++---
src/backend/rewrite/rewriteManip.c | 138 ++++++--------------------
src/include/rewrite/rewriteManip.h | 17 +++-
src/tools/pgindent/typedefs.list | 1 +
4 files changed, 192 insertions(+), 124 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2025-05-07 08:47:24 | Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback |
Previous Message | Peter Eisentraut | 2025-05-07 06:24:34 | pgsql: doc: Fix up spacing around verbatim DocBook elements |