| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback |
| Date: | 2025-05-07 08:51:06 |
| Message-ID: | CAPpHfdvf+OF8qERNX5uQaygS3oHcAYoSSvyn4WpF9vW1BiCamg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, May 7, 2025 at 11:47 AM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
> > Refactor ChangeVarNodesExtended() using the custom callback
> >
> > fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic
> > to ChangeVarNodes_walker(). This commit provides refactoring to remove the
> > SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to
> > ChangeVarNodesExtended(), which has a chance to process a node before
> > ChangeVarNodes_walker(). Passing this callback to ChangeVarNodesExtended()
> > allows SJE-related node handling to be kept within the analyzejoins.c.
>
> I believe this was pushed by mistake.
Why it should be mistake this time?
At least, this time I managed to wait till the end of release freeze.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-05-07 08:59:29 | Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback |
| Previous Message | Aleksander Alekseev | 2025-05-07 08:47:24 | Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback |