| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Typo with amtype = 's' in opr_sanity.sql |
| Date: | 2023-11-21 10:02:40 |
| Message-ID: | CAJ7c6TOsBVSn46_M6QnWOZtPSPvZMGi-+M8sSaDdtqyWZNCtBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> While rebasing a patch from 2016 related to sequence AMs (more about
> that later), I've bumped on a mistake from 8586bf7ed888 in
> opr_sanity.sql, as of:
> +SELECT p1.oid, p1.amname, p2.oid, p2.proname
> +FROM pg_am AS p1, pg_proc AS p2
> +WHERE p2.oid = p1.amhandler AND p1.amtype = 's' AND
Good catch.
> It seems to me that this has been copy-pasted on HEAD from the
> sequence AM patch, but forgot to update amtype to 't'. While that's
> maybe cosmetic, I think that this could lead to unexpected results, so
> perhaps there is a point in doing a backpatch?
I disagree that it's cosmetic. The test doesn't check what it's supposed to.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vitaly Davydov | 2023-11-21 10:18:06 | Re: How to accurately determine when a relation should use local buffers? |
| Previous Message | John Naylor | 2023-11-21 09:42:55 | Re: Change GUC hashtable to use simplehash? |