Re: Typo with amtype = 's' in opr_sanity.sql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Typo with amtype = 's' in opr_sanity.sql
Date: 2023-11-22 00:34:24
Message-ID: ZV1MkCIf4zI0ilJU@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 21, 2023 at 01:02:40PM +0300, Aleksander Alekseev wrote:
>> It seems to me that this has been copy-pasted on HEAD from the
>> sequence AM patch, but forgot to update amtype to 't'. While that's
>> maybe cosmetic, I think that this could lead to unexpected results, so
>> perhaps there is a point in doing a backpatch?
>
> I disagree that it's cosmetic. The test doesn't check what it's supposed to.

Yes, I've backpatched that all the way down to 12 at the end.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-11-22 01:17:30 Re: pg_upgrade and logical replication
Previous Message Bruce Momjian 2023-11-22 00:31:06 Re: [HACKERS] legitimacy of using PG_TRY , PG_CATCH , PG_END_TRY in C function