| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-06-15 14:51:06 |
| Message-ID: | CAJ7c6TO_QBjMfLkDRgi2ceBZkvMYG_9GRvzboitBfN3PoJoqxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I noticed that cfbot is not entirely happy with the patch, so I rebased it.
> I see that COMPRESSION and STORAGE now are handled slightly
> differently in the grammar. Maybe we could standardize that a bit
> more; so that we have only one `STORAGE [kind]` definition in the
> grammar?
>
> As I'm new to the grammar files; would you know the difference between
> `name` and `ColId`, and why you would change from one to the other in
> ALTER COLUMN STORAGE?
Good point, Matthias. I addressed this in 0002. Does it look better now?
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-CREATE-TABLE-.-STORAGE.patch | application/octet-stream | 14.1 KB |
| v3-0002-Handle-SET-STORAGE-and-SET-COMPRESSION-similarly.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2022-06-15 15:36:47 | Re: support for MERGE |
| Previous Message | Andrey Borodin | 2022-06-15 14:39:34 | Re: [PATCH] Add sortsupport for range types and btree_gist |