| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-06-22 13:25:48 |
| Message-ID: | 7a2883e1-ce7d-65cb-4ef7-a7822e5e4b46@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.06.22 16:51, Aleksander Alekseev wrote:
> I noticed that cfbot is not entirely happy with the patch, so I rebased it.
>
>> I see that COMPRESSION and STORAGE now are handled slightly
>> differently in the grammar. Maybe we could standardize that a bit
>> more; so that we have only one `STORAGE [kind]` definition in the
>> grammar?
>>
>> As I'm new to the grammar files; would you know the difference between
>> `name` and `ColId`, and why you would change from one to the other in
>> ALTER COLUMN STORAGE?
>
> Good point, Matthias. I addressed this in 0002. Does it look better now?
In your patch, the documentation for CREATE TABLE says "SET STORAGE",
but the actual syntax does not contain "SET".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-06-22 13:29:24 | Re: CREATE TABLE ( .. STORAGE ..) |
| Previous Message | Drouvot, Bertrand | 2022-06-22 13:25:22 | SYSTEM_USER reserved word implementation |