| From: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG |
| Date: | 2026-08-22 00:58:37 |
| Message-ID: | CAHza6qcjyGePxG+6FVQS8Vr02pCt7rgQ5TU7+65Lsg3V6rWCAQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Sorry for the late reply, and thanks for taking this over!
> So question time: Is this debugging code still relevant and wouldn't
> it be better to just remove it? It looks pretty clear to me that
> nobody is using this #define at all, or this failure would have been
> noticed a long time ago.
Removing the whole thing sounds good to me.
I agree that none of this infrastructure is used by anybody these days.
> Please find attached a patch to clean up execdebug.h and its APIs.
> How does that look?
I have checked the patch on my side: the tree builds cleanly, make
check passes, and I could not find any remaining references to
execdebug.h or to the macros it used to define.
LGTM.
Regards,
Tatsuya Kawata
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-08-22 01:06:33 | Wrong results from join removal with DISTINCT ON + SRF subquery |
| Previous Message | Michael Paquier | 2026-08-21 23:52:46 | Re: [PATCH] Several refactorings for pg_dump |