| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG |
| Date: | 2026-08-21 14:34:03 |
| Message-ID: | 4074786.1787322843@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sun, Aug 16, 2026 at 10:26:33AM -0400, Tom Lane wrote:
>> +1. I'd be inclined to think about removing execdebug.h altogether.
>> If this style of debug support were really useful, it would have
>> migrated into more than three kinds of executor node by now.
> Please find attached a patch to clean up execdebug.h and its APIs.
> How does that look?
LGTM. There are a few places in the calling files where I might've
removed more blank lines than you did, or removed no-longer-necessary
brace pairs, but that's all a matter of taste.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-08-21 14:35:58 | Re: Apply extended statistics to join clause during parameterized path costing |
| Previous Message | Fujii Masao | 2026-08-21 14:26:57 | Re: [PATCH] doc: clarify AS requirement when VALUES used in a FROM clause |