| From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix for readline terminal size problems when window is resized with open pager |
| Date: | 2015-12-16 19:02:04 |
| Message-ID: | CAHyXU0xcfmGy5BHay-DRKpqR3j0FSzfCFJcr9YS=28+0H+jhVQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 12:06 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-12-16 13:02:25 -0500, Tom Lane wrote:
>> I think the most reasonable way to handle this is to put the
>> call into a new function exported from input.c, where it can be
>> made conditional on useReadline.
>
> Sounds good.
I'll right, I'll follow up with that shortly.
For posterity, I think you guys arrived at the right conclusion, but
the difference between the two public screen reset calls is that one
(the original patch) forces a re-display of the prompt and the newer
one, rl_reset_screen_size(), does not. With the older patch the best
I could come up with was to call rl_crlf() so that the prompt display
did not amend to the end of \timing's output. However, that still
modified the output relative to what it was pre-patch, which would be
impolite to our users in a backpatch scenario.
merlin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2015-12-16 19:27:33 | Re: checkpointer continuous flushing |
| Previous Message | Robert Haas | 2015-12-16 18:31:05 | Re: Speed up Clog Access by increasing CLOG buffers |