| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix for readline terminal size problems when window is resized with open pager |
| Date: | 2015-12-16 18:06:05 |
| Message-ID: | 20151216180605.GI23112@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-12-16 13:02:25 -0500, Tom Lane wrote:
> > If we really want to we could basically directly use
> > _rl_get_screen_size() - which seems to have been present from before
> > 4.0. It's not declared static...
>
> Nah, I don't think we should rely on calling undocumented internal
> readline functions.
Agreed.
> We've lived with this behavior for long enough
> that I don't think it's a catastrophe if we don't fix it for ancient
> readline releases.
Yes.
> I think the most reasonable way to handle this is to put the
> call into a new function exported from input.c, where it can be
> made conditional on useReadline.
Sounds good.
> Does anyone object to back-patching it?
Not here.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2015-12-16 18:11:10 | Re: checkpointer continuous flushing |
| Previous Message | Tom Lane | 2015-12-16 18:02:25 | Re: fix for readline terminal size problems when window is resized with open pager |